Open
Conversation
added 2 commits
November 18, 2019 09:30
grimzy
approved these changes
Nov 18, 2019
| return False | ||
|
|
||
| # Oauth2 authentication method | ||
| def authenticate_authorization_code(self, client_id, client_secret, authorizaion_code='eBGI9tpcMrBZwD9Yguqz'): |
There was a problem hiding this comment.
I'd suggest removing the authorization_code's default value since the code is required by the request and quickly expires (default value becomes obsolete).
obi11235
approved these changes
Jan 9, 2020
obi11235
left a comment
obi11235
left a comment
There was a problem hiding this comment.
I'd remove the auth code default if there isn't a reason for it, feels wrong, other than that looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a method to enable authorization codes (with refresh tokens) in addition to client credentials.