Skip to content

Conversation

@nilsreichardt
Copy link
Member

You couldn't open the links sent in the feedback chat.

@github-actions github-actions bot added dependencies Changing, updating, adding or removing one or more dependencies. feature: feedback Users can send us feedback to improve the app. labels Sep 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nilsreichardt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical usability bug within the feedback chat feature where users were unable to open links shared in messages. By incorporating a dedicated URL launcher and configuring the markdown renderer, the change ensures that all links are now interactive and functional, enhancing the overall user experience and communication flow.

Highlights

  • Link Functionality Fix: Resolved an issue where links sent in the feedback chat were not clickable or opening, significantly improving user interaction within the chat.
  • Dependency Integration: Integrated the url_launcher_extended package to provide robust URL launching capabilities within the application.
  • Markdown Link Handling: Configured the MarkdownBody widget to properly handle link taps, ensuring that all embedded URLs are now actionable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where links in the feedback chat could not be opened. The approach of using the onTapLink callback from MarkdownBody is correct. However, the current implementation has a critical flaw: it attempts to launch the link's display text as a URL instead of the actual URL (href). Additionally, it lacks error handling for cases where the URL is invalid or cannot be launched. I've provided a suggestion to fix these issues, ensuring that the correct URL is used and that users are notified if a link fails to open.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Visit the preview URL for this PR (updated for commit 14afe58):

https://sharezone-website-dev--pr1937-fix-url-in-feedback-11rouva7.web.app

(expires Mon, 22 Sep 2025 16:58:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Visit the preview URL for this PR (updated for commit 14afe58):

https://sharezone-console-dev--pr1937-fix-url-in-feedback-n63mhhkq.web.app

(expires Mon, 22 Sep 2025 16:58:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6

nilsreichardt and others added 2 commits September 19, 2025 09:53
…ils_page.dart

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 14afe58):

https://sharezone-test--pr1937-fix-url-in-feedback-7gk1i6ip.web.app

(expires Mon, 22 Sep 2025 16:59:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're security conscious, we should maybe add a pop-up that displays the URL and a button to continue opening it.

That's because people could write a link like this: https://www.google.com which actually leads to another destination (phishing, malware, etc.)

(Or some other way which balances security with usability so one doesn't need to click another button always)

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Changing, updating, adding or removing one or more dependencies. feature: feedback Users can send us feedback to improve the app.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants