-
-
Notifications
You must be signed in to change notification settings - Fork 57
Fix opening links in feedback chat #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @nilsreichardt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical usability bug within the feedback chat feature where users were unable to open links shared in messages. By incorporating a dedicated URL launcher and configuring the markdown renderer, the change ensures that all links are now interactive and functional, enhancing the overall user experience and communication flow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue where links in the feedback chat could not be opened. The approach of using the onTapLink callback from MarkdownBody is correct. However, the current implementation has a critical flaw: it attempts to launch the link's display text as a URL instead of the actual URL (href). Additionally, it lacks error handling for cases where the URL is invalid or cannot be launched. I've provided a suggestion to fix these issues, ensuring that the correct URL is used and that users are notified if a link fails to open.
lib/feedback_shared_implementation/lib/src/pages/feedback_details_page.dart
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit 14afe58): https://sharezone-website-dev--pr1937-fix-url-in-feedback-11rouva7.web.app (expires Mon, 22 Sep 2025 16:58:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e |
|
Visit the preview URL for this PR (updated for commit 14afe58): https://sharezone-console-dev--pr1937-fix-url-in-feedback-n63mhhkq.web.app (expires Mon, 22 Sep 2025 16:58:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6 |
…ils_page.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit 14afe58): https://sharezone-test--pr1937-fix-url-in-feedback-7gk1i6ip.web.app (expires Mon, 22 Sep 2025 16:59:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're security conscious, we should maybe add a pop-up that displays the URL and a button to continue opening it.
That's because people could write a link like this: https://www.google.com which actually leads to another destination (phishing, malware, etc.)
(Or some other way which balances security with usability so one doesn't need to click another button always)
WDYT?
You couldn't open the links sent in the feedback chat.