Add List, Pull & Push IAdbClient extension methods #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Using the extension methods instead of the SyncService directly also fixes #19 |
Member
|
It's also a solution 🤣. |
wherewhere
added a commit
that referenced
this pull request
Jan 17, 2023
…sions Add List, Pull & Push IAdbClient extension methods
|
Did anyone even tried to use Pull method? It just doesn't work. Socket does dispose sooner than necessary. Removing using statement fixes it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the Stat extension method in DeviceCommands.cs I added similar methods for List, Pull, and Push. You can now do stuff like listing directories in parallel or downloading files in parallel. The cost is that each sync request opens and closes a new socket, but it seems be fast enough using an USB connection to my Samsung device.
I think the reason that re-using a SyncService for multiple sync requests fails is related to this "Sync mode is
implicitly exited after each sync request, and normal adb communication follows" (from https://android.googlesource.com/platform/system/adb/+/refs/heads/master/SYNC.TXT), but I don't know for sure.