Merged
Conversation
bring over primer feature handling for analyze_dataset and full_analysis, plus a sanity check for handle_primers
fixed stats::reorder in primers.R that should be here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reorganizes the configuration system to use R's global
options()features instead of a list, and to manage CHIIMP configuration options as CSV tables and simple data frames rather than YAML and nested lists. This should make configuration options less cumbersome to manage within the package, and make config files easier to manage for people not familiar with YAML. The old .yml files will still work, but internally they will be parsed into data frames and handled with the new workflow.