Skip to content

Peleg's feedback #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pelegwain wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Peleg's feedback #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d78b77c
Add feedback #2
pelegwain Mar 25, 2020
e375b4a
Update HALLOFFAME.md
pelegwain Mar 25, 2020
0641d0e
Merge branch 'dev' into dev
ShayNehmad May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .management/feedback/2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
Peleg Wainberg -

Existing stages suggestions:
Stage 5: Changed to 66, opened a PR to ShayNehmad/sylvanly-narrower-oxboy, travis gave me the flag. Felt wrong so I re-did the stage.
Stage 7: The face that only part of the tag name is the next stage's branch name was unclear. Also, I think it's too "passive" - it's very clear that I only need to find the tag name of a given commit.
Stage 9: the loop adds 102 files lol. Also, the hook will always return 1 - was that on purpose?
Stage 10: I didn't even have to read the hook to pass. Maybe make people write a hook and validate it?

Other Suggestions:
- Add a git bisect stage! it can be cool (and not that hard). Easy part can be manually finding the bad commit, Advanced part can be writing a script that finds it and letting git bisect to the work for you!
- Add people to the leaderboard automatically!
- Add a more advanced rebase exercises.
- Add stages for squash, ammend, reset (different types). Maybe something for stash, restore, clean


I really enjoyed doing this and learned quite a bit :)

* On the final stage, it would help if you linked to previous stages. I want to write some feedback and can't remember all the stage names.
* Stage 2 - The wording "Check out the next stage" threw me off. I thought I had to find something in "staging" and didn't realise at first that the flag was the branch name. *facepalm emoji*
* Stage 3 - It took me a while to realise that here too I need to do a pull request.
* FInal 10 - I copied the commit-msg.sample to the working directory. It was a complete guess but it worked. Wasn't sure if that was what I was supposed to do.

1 change: 1 addition & 0 deletions HALLOFFAME.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ Good job, you finished the CTF! 🚩🏆
- [Daniel Goldberg](https://github.com/danielguardicore)
- [Liad Mordekoviz](https://github.com/liadmord)
- [Yair Shemla](https://github.com/yairshemla)
- [Peleg Wainberg](https://github.com/pelegwain)
- [Benji Tobias](https://github.com/benjitobias)
- [Stiv Kupchik](https://github.com/kupsul)