Fix quick reply crash#10
Merged
davidrussell731 merged 2 commits intoShellMonkeys:masterfrom Apr 25, 2017
Merged
Conversation
davidrussell731
approved these changes
Apr 25, 2017
Collaborator
davidrussell731
left a comment
davidrussell731
left a comment
There was a problem hiding this comment.
Good idea! This is how we using the library, so putting it in the constructor works for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per readme, I tried to implement the quickReply but it crashed on a rather interesting error:
It seemed the quickReply required an extra param, the payload to be defined. As I kinda liked the style that the readme went with; I just added a fallback. So it will use the payload when given and fallback to the title when not.
Hope you like it & nice work!