Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Fix circular file dependency#37

Merged
Shinmera merged 1 commit intoShinmera:masterfrom
Gleefre:fix-file-dependencies
May 7, 2025
Merged

Fix circular file dependency#37
Shinmera merged 1 commit intoShinmera:masterfrom
Gleefre:fix-file-dependencies

Conversation

@Gleefre
Copy link
Copy Markdown
Contributor

@Gleefre Gleefre commented May 7, 2025

Fixes #36 by splitting constant definitions into two files.

Specifically, infinity constants are moved to inifinity.lisp to be loaded before float-features.lisp, and nan constants are moved to nan.lisp to be loaded after (as before the merge in da01c1c).

This is needed because the infinity constants are used in the definition of bits-short-float, which in turn is used to define SHORT-FLOAT-NAN:

((zerop sign)
single-float-positive-infinity)
(t
single-float-negative-infinity))

(handler-case
(progn
(bits-short-float 0)
(defconstant SHORT-FLOAT-NAN
(bits-short-float #b0111111000000000)))
(error ()
(define-symbol-macro SHORT-FLOAT-NAN
(bits-short-float #b0111111000000000))))

@Shinmera Shinmera merged commit b1e8bd9 into Shinmera:master May 7, 2025
0 of 8 checks passed
@Shinmera
Copy link
Copy Markdown
Owner

Shinmera commented May 7, 2025

Thanks!

@Gleefre Gleefre deleted the fix-file-dependencies branch May 7, 2025 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undefined variables float-features:single-float-{positive,negative}-infinity

2 participants