Skip to content

Rails and git dependency #8

@oleksii-ti

Description

@oleksii-ti

in lib/shiphawk/helpers/request.rb Rails module is used thought there is no rails dependency in project

5  module Helpers
6   
7       module Request
8   
9         APP_VERSION = IO.popen(['git', 'rev-parse', 'HEAD', :chdir => Rails.root]).read.chomp
 
40            conn.use :extended_logging, logger: Rails.logger
41  

Also this APP_VERSION = IO.popen(['git', 'rev-parse', 'HEAD', :chdir => Rails.root]).read.chomp means than project could be used only from git directory which is hardly possible for one who going only use it as gem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions