Add date-range filter for finished jobs#6
Open
Shivareddy-Aluri wants to merge 1 commit intomasterfrom
Open
Conversation
Allow filtering completed/finished jobs by a date preset. - Add date preset UI to Filterable: introduce TEXT_FIELDS, DATE_FIELD and DATE_PRESETS, manage active preset, render date field, and handle keyboard interactions (j/k to cycle, tab/back_tab to change fields). Update filter application/clearing to include date preset state and include the preset label in filter titles and bindings. - Wire the date range into data queries: add since parameter to Data::JobsQuery.fetch and .count and apply finished_at >= since in fetch_finished and count_finished. - Update the application to pass the since value when loading/appending finished jobs and update the help text for the filter action. - Enable the date preset field in the Finished view by overriding filter_fields. This change makes it possible to view completed jobs limited to common recent time ranges (last hour, 6h, 24h, 7d, 30d, or all time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow filtering completed/finished jobs by a date preset.
This change makes it possible to view completed jobs limited to common recent time ranges (last hour, 6h, 24h, 7d, 30d, or all time).