Add support for mka (external audio track)

[bigretromike]

Description

As some of release have mka with seperate audio shoko ignore them while scanning;
would be nice to move them with mkv's

[da3dsoul]

Add to the settings

[da3dsoul]

app.config:68 and settings.json

[bigretromike]

<add key="VideoExtensions" value="MKV,AVI,MP4,MOV,OGM,WMV,MPG,MPEG,MK3D,M4V" />

mka is audio file

[da3dsoul]

So, what? Should we treat it as a subtitle file for most cases, but skip adding it to the stream list as a subtitle. I don't know how that's supposed to look in stream info for an mkv, as separate audio files is just weird.

[bigretromike]

extermal audio file. also even if added to videoextension it will skan it and hash will not match anything.
those are common for 'commentary' or external dubs without muxing files.
found few of them.
I copy them by hand but eventualy is shoko isin't aware of them it can end up not working (thanks to rename)
its part of release
Just saying

[da3dsoul]

I see. I can imagine that would cause issues

[da3dsoul]

I don't know if/how we could pass it to Nakamori or another streamed player, but at least making it copy and break is feasible.

[bigretromike]

Dunno about streamed player, but the Shoko Desktop/clientv2 would definitely be able to use this...

[da3dsoul]

Desktop uses the streamed player of it's not on localhost

[bigretromike]

but local 100% support it

[maxpiva]

If is treated as a subtitle, streamed will get it also.

…

On Wed, Feb 1, 2017 at 1:44 PM, BigRetroMike ***@***.***> wrote: but local 100% support it — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#567 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHDbW9mGAoKB-ZoODnLomSwzjeReC9lks5rYLZkgaJpZM4LznX0> .

[bigretromike]

so there is a green light, good. thanks @maxpiva

[maxpiva]

Well, code should be added in the Media object, so clients knows, there is something in there. And in the clients, handle the case of extra audio track, Donno how to handle that info to the players. (That could be a problem). For copying pruposes, adding the type mka as a subtitle will suffice.

[bigretromike]

maybe we could add extra "Audio" something or add it as default ? as its not intuited to add external audio to subtitle

[da3dsoul]

The point is that it's up to the player to parse an external audio track. Some do it differently than others, and we aren't sure that mka follows a standard