This repository was archived by the owner on Aug 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 513
Mobile menu and new ajax cart drawer #338
Merged
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
d7d5ad5
Setup drawer skeleton
cshold 8df785e
Remove unneeded ajax cart toggle methods
cshold 6da3b03
Fully removed flip method. New mobile-nav snippet. Updated mobile header
cshold 283ea6a
Remove modal support. Add function to run when drawer opens
cshold ed6ddca
Stripped more ajax js away. Returned to familiar timber header layout
cshold bb2224d
Removed more unneeded settings/js vars
cshold 10c4594
More deletions. Less complexity
cshold 35ad2c8
Drawer header styles
cshold e53e348
Drawer header style updates
cshold 12c890a
Mobile nav styles
cshold 25fe36a
Mobile nav toggle JS
cshold 637048d
Minor drawer styling updates
cshold 3e124a1
Removed more unused code. New ajax cart layout.
cshold d5ee3a6
Nicer hit areas on mobile nav with new styles
cshold 929a0d1
External callback for opening cart drawer. Removed unused label
cshold d640009
Move search bar to header above nav
cshold ed90880
Login/logout/search moved to mobile nav
cshold fa183de
Mobile subnav and cart css animations
cshold cb98772
Unified thickness of some icons
cshold 11ef9b8
Minor Windows style fixes
cshold e19aba8
Drawer cart grid spacing
cshold 93924c4
Big clean of drawer styles, flexible by color. Merged ajax cart style…
cshold 8bf2bb5
Fix drawer page scroll issue
cshold 8f6759b
Minor link and cart page style updates
cshold b3099c2
New mobile subnav animation
cshold 2563945
Remove item from cart animation
cshold d0be940
Minor style updates
cshold 7fea2b5
Revert changed unecessary to this PR
cshold 4a670fd
Fixed qty/price alignment in cart drawer
cshold 9617533
Remove is-added and is-adding class on button if errors occur
cshold c10280e
Updated form submission syntax
cshold a2a68c5
Syntax fix on last commit
cshold bee9aea
Comment for source of drawer JS
cshold d505bc8
Version bump
cshold 81fde43
Fix input border colours in drawer
cshold e68f285
Removed unused strings
cshold 8f41624
Organize z-index in variables
cshold 94add3b
Removed data attributes no longer needed on cart template
cshold 255178c
Organized afterCartLoad placement
cshold 828ea54
Switch to custom events for after cart callback
cshold 82d8d73
Added translation to drawer elements
cshold 920a43e
Proper event delegation
cshold 38afcd9
Wrap additional checkout buttons in div, not p
cshold 98087f6
Add cart note to ajax cart drawer
cshold cf666d3
Added optional vendor to ajax cart
cshold 457451e
Renamed product meta class
cshold 1e91951
Max image width fix
cshold 398e5ab
Actual logo max width fix
cshold d0343f3
Specific class on logo for max-width fixe in FF
cshold 7b897f9
Another minor icon font update
cshold 6d059f5
Added dropdown arrow in nav
cshold 98eca1f
Removed logo margins
cshold 30e0e1d
Remove side padding on Paypal input buttons
cshold bfdb1b9
Using mixin for user-select
cshold ad0e856
New down arrow icon font (for sizing)
cshold 7f3cd11
Sized down arrow in menu
cshold 75d9dc0
Less specific drawer styles. Sidebar default list styles
cshold d23bd7f
Combined list styles properly
cshold d11cafa
Removed unneeded styles
cshold 6881ee5
Allow html in handlebar prices
cshold 1aa1721
Remove unused ajax cart helpers
cshold 9eb509b
Remove conditional cart classes. Drawer transition var.
cshold bd70f85
Descriptive css comments
cshold 1c63024
Temporarily revert to ajaxify.js.liquid
cshold 286aa2d
Git renamed ajax-cart.js.liquid
cshold f9c046f
Proper git rename of ajax-cart with updates
cshold 8cde711
Move formatMoney to always-present timber.js
cshold 4c91d5c
Update drawer js comment
cshold 6fa6f14
Rename ajax cart api functions
cshold abc2b76
Minor comment update about addItemFromForm method
cshold c2e7c1b
Removed formatMoney from ajax js. Lives in timber.js
cshold afad035
Make sure Shopify namespace exists in timber.js
cshold 9ea7381
Merge pull request #3 from cshold/ajax-cart-api
cshold 9af35c8
Slight update to api comments
cshold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,8 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- Generator: Adobe Illustrator 17.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="Layer_1" x="0px" y="0px" width="8px" height="13px" viewBox="0 0 8 13" enable-background="new 0 0 8 13" xml:space="preserve"> | ||
| <g> | ||
| <g> | ||
| <polygon fill="{{settings.color_borders}}" points="0,8 4,13 8,8 "/> | ||
| </g> | ||
| </g> | ||
| <g> | ||
| <g> | ||
| <polygon fill="{{settings.color_borders}}" points="4,0 0,5 8,5 "/> | ||
| </g> | ||
| </g> | ||
| </svg> | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- Generator: Adobe Illustrator 18.1.1, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" | ||
| width="8px" height="5px" viewBox="0 0 8 5" enable-background="new 0 0 8 5" xml:space="preserve"> | ||
| <path fill="{{settings.color_borders}}" d="M0,0c0,0,3.4,4.4,3.5,4.4C3.7,4.4,7.1,0,7.1,0H0z"/> | ||
| </svg> | ||
|
|
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open question, is the mobile drawer a pattern we'd like to encourage for all mobile-ready themes?
cc @pauldpritchard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encourage, but not make mandatory. It's better than most of the mobile nav solutions we've created so far, but wouldn't fit into every theme's style from my point of view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we document requirements vs encouragements?