Make the at-query more intuitive for min-max calls

[jtgrenz]

I modified the at-query mixin to make calling values of in-between a little more intuitive.
Currently if you want to define a media query between two ranges, say small and medium, you'd write:
@include at-query(null, $small, $medium) { ... }

I don't like passing in null values and sass is smart enough to figure out whats what. So with this change,
@include at-query(null, $small, $medium) { ... } and @include at-query( $small, $medium) { ... } are identical.

if you were used to adding null to do an in-between, it works, but if you wanted a short hand, that works too.

@carolineschnapp

[carolineschnapp]

This adds some welcomed smarts to a function that isn't as intuitive as it could be.

I can't comment on the actual code edit, I am not an experienced Sassy coder, but I like that we can call the function with a min and max values. 👍

[carolineschnapp]

@cshold what do you think?

[cshold]

Looks like a smart way to call the function, and I like that it still works with the long syntax. Let me test it out a bit tomorrow and get back to you.

[cshold]

@Shopify/fed Thoughts on this approach to make a more intuitive at-query mixin?

[snookca]

I'm a bigger fan of using named arguments.

[mpiotrowicz]

I as well, but this is an improvement I think

[AWaselnuk]

The type-of check seems brittle to me. What if someone does at-query('100px')?

[jtgrenz]

@AWaselnuk at-query('100px') wouldn't work in either case. Existing code using strings for the values should work the same since they would be defined with long form of the function or they would be passing in $min or $max to the constraint. Anyone trying to use the short form with a string would trip an error though, but if you forget to add null right now, you also get an error.

There is an article on casting string values to numbers but its definitely overkill.

[AWaselnuk]

Agreed that casting would be a bad idea.
As long as an error is thrown for invalid argument type then it should be fine.

[cshold]

Opened #367 to include link to docs and slight syntax update.