This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
can you add HTML comments denoting the start/end to the old snippets? I think it would go a long way in helping ppl navigate this file.
Eg
// begin mobile nav
Contributor
|
this is great! Were any of the snippets un-snippified twice? (eg snippet contents appear twice now) |
Contributor
Author
|
Nope, no un-snippification, aka no reused code that doesn't live in a snippet. I'll give it another once over to make sure that's the case though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evolution of #358
This PR also:
cc @carolineschnapp @mpiotrowicz @stevebosworth @fredryk