Skip to content
This repository was archived by the owner on Aug 30, 2018. It is now read-only.

i18n for varying price label#389

Merged
cshold merged 1 commit intomasterfrom
twitter-card-price
Apr 9, 2015
Merged

i18n for varying price label#389
cshold merged 1 commit intomasterfrom
twitter-card-price

Conversation

@cshold
Copy link
Contributor

@cshold cshold commented Apr 9, 2015

Following on the work by @schaeken in https://github.com/Shopify/shopify-themes/pull/1259, using i18n-friendly translations for From $xx.xx.

This covers the Twitter card meta data, product grid items, and search results (grid and list views).

@stevebosworth @mpiotrowicz

@cshold cshold added the i18n label Apr 9, 2015
@stevebosworth
Copy link
Contributor

👍

@schaeken
Copy link
Contributor

schaeken commented Apr 9, 2015

Awww thanks carson!!!!! :D

cshold added a commit that referenced this pull request Apr 9, 2015
@cshold cshold merged commit 142d3e5 into master Apr 9, 2015
@cshold cshold deleted the twitter-card-price branch April 9, 2015 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants