This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Change collection list paginate by count to match collection#445
Merged
cshold merged 1 commit intoShopify:masterfrom Jun 30, 2015
Merged
Change collection list paginate by count to match collection#445cshold merged 1 commit intoShopify:masterfrom
cshold merged 1 commit intoShopify:masterfrom
Conversation
Contributor
|
Hadn't even considered that to be a potential issue, but great catch. Thanks! |
cshold
added a commit
that referenced
this pull request
Jun 30, 2015
Change collection list paginate by count to match collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a theme review with the Shopify team having different paginate by counts for the collection and collection list views came up as an issue. Here are the steps to recreate the potential bug with mismatched pagination counts:
It was incredibly helpful having Timber as a guideline to work from for our first theme. Hopefully this small change will help someone else.