This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Conversation
|
Looks good to me on my test shop. The whitelist idea is great 👍 |
|
Haven't Laser, Switch and Solo been killed off now, replaced by Maestro and Visa? https://en.wikipedia.org/wiki/Solo_%28debit_card%29 |
Contributor
Author
|
Yup, it looks like those are no longer active yet still show up as available methods in Shopify source. I'll ask around about getting the legacy payment methods fully removed, then update the icon set again once they are. |
Contributor
Author
|
For those that couldn't see the private link above, it was about icon alignment — specifically with Instagram and Google+. I went through and updated every icon we have to be better aligned and sized.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New payment icons
By looping through all
shop.enabled_payment_typesin the footer, we're suseptible to showing new payment types before an icon is added to Timber's icon set. I've added in a whitelist to only hold the ones we have icons for.Other new icons
google-plus, instead ofgoogle)@stevebosworth @Lisa-Villeneuve @carolineschnapp