This repository was archived by the owner on Jun 13, 2018. It is now read-only.
UPS. Ability to Bill Third Party for Duties and Taxes#354
Merged
eboswort merged 2 commits intoShopify:masterfrom Apr 28, 2016
Merged
UPS. Ability to Bill Third Party for Duties and Taxes#354eboswort merged 2 commits intoShopify:masterfrom
eboswort merged 2 commits intoShopify:masterfrom
Conversation
Contributor
|
Hey @eboswort. Sorry I missed this. Change looks good! 👍 |
Contributor
Author
|
Awesome! Thanks, I'll merge. |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
UPS. Ability to Bill Third Party for Duties and Taxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to bill duties and taxes to a third party shipping account.
Also contained in this PR is a change to actually use parameter
negotiated_rateswhich was already documented above thecreate_shipmentmethod definition. We were inferring that based on the presence of anorigin_accountbut given that negotiated rates are based on who's paying, the existence of third party billing means it doesn't really make sense to do that. However this could be a breaking change for anyone relying on theorigin_accountto automatically turn on negotiated rates.Really I think we should probably rename
origin_accountto beshipper_accountsince that's a better description of what it is.