This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Add ResponseContentError for raised UPS error#357
Merged
jonathankwok merged 1 commit intoShopify:masterfrom Apr 27, 2016
jgillman:add-response-content-error-for-ups
Merged
Add ResponseContentError for raised UPS error#357jonathankwok merged 1 commit intoShopify:masterfrom jgillman:add-response-content-error-for-ups
jonathankwok merged 1 commit intoShopify:masterfrom
jgillman:add-response-content-error-for-ups
Conversation
Contributor
|
Thanks for the fix @jgillman! |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Add ResponseContentError for raised UPS error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors from UPS were getting thrown as runtime errors which are harder to catch. This change mirrors how errors are thrown in the FedEx carrier.