Skip to content
This repository was archived by the owner on Jun 13, 2018. It is now read-only.

Allow for optional FedEx package label stock type (label dimensions)#366

Merged
jonathankwok merged 1 commit intoShopify:masterfrom
adacosta:feature/fedex-label-stock-type-option
May 17, 2016
Merged

Allow for optional FedEx package label stock type (label dimensions)#366
jonathankwok merged 1 commit intoShopify:masterfrom
adacosta:feature/fedex-label-stock-type-option

Conversation

@adacosta
Copy link
Copy Markdown
Contributor

@adacosta adacosta commented May 6, 2016

Currently, a hard coded value of 'PAPER_7X4.75' is supplied for every package label. The FedEx WebServices Developers Guide says:

When using an ImageType of PDF or PNG, these values display a thermal format label:
  PAPER_4X6
  PAPER_4X8
  PAPER_4X9
these values display a plain paper format shipping label:
  PAPER_7X4.75
  PAPER_8.5X11_BOTTOM_HALF_LABEL
  PAPER_8.5X11_TOP_HALF_LABEL

I've allowed for the default (no option specified) to retain the current functionality. In other words, 'PAPER_7X4.75' will be used without a specified option.

In addition to the automated tests, I've manually tested with 'PAPER_4X6' (what I need for a thermal printer)

Sample use:

carrier.create_shipment(location_1, location_2, [package], test: true, label_stock_type: 'PAPER_4X6')

@jonathankwok
Copy link
Copy Markdown
Contributor

Hey, thanks for putting this PR out! Everything looks great, I can merge it in for you.

CC: @mdking

@adacosta
Copy link
Copy Markdown
Contributor Author

thanks @jonathankwok

@mdking
Copy link
Copy Markdown
Contributor

mdking commented May 17, 2016

👍

@jonathankwok jonathankwok merged commit 662c05f into Shopify:master May 17, 2016
maartenvg pushed a commit that referenced this pull request Nov 9, 2017
…option

Allow for optional FedEx package label stock type (label dimensions)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants