This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Allow for optional FedEx package label stock type (label dimensions)#366
Merged
jonathankwok merged 1 commit intoShopify:masterfrom May 17, 2016
Merged
Conversation
Contributor
|
Hey, thanks for putting this PR out! Everything looks great, I can merge it in for you. CC: @mdking |
Contributor
Author
|
thanks @jonathankwok |
Contributor
|
👍 |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
…option Allow for optional FedEx package label stock type (label dimensions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a hard coded value of 'PAPER_7X4.75' is supplied for every package label. The FedEx WebServices Developers Guide says:
I've allowed for the default (no option specified) to retain the current functionality. In other words, 'PAPER_7X4.75' will be used without a specified option.
In addition to the automated tests, I've manually tested with 'PAPER_4X6' (what I need for a thermal printer)
Sample use: