This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Add cancel_shipment to the interface#374
Merged
jonathanmwatson merged 1 commit intomasterfrom May 18, 2016
Merged
Conversation
lib/active_shipping/carrier.rb
Outdated
| # the carrier | ||
| # @return [ActiveShipping::ShipmentResponse] The response from the carrier. This | ||
| # response in most cases has a cancellation id. | ||
| def cancel_shipment(shipment_id) |
Contributor
There was a problem hiding this comment.
Following with the existing pattern of the interface methods can you add a second argument options = {}
jonathanmwatson
force-pushed
the
adding-cancel-shipment-to-interface
branch
from
f39f8cd to
5b88d08
Compare
jonathanmwatson
force-pushed
the
adding-cancel-shipment-to-interface
branch
from
5b88d08 to
78a80be
Compare
Contributor
|
👍 |
Contributor
|
Good idea. 👍 |
Contributor
|
Looks good. 🚢 |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Add cancel_shipment to the interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add cancel_shipment to the interface. Will create an issue to come back and add in actual functionality to all carriers we have implemented.
I think this is everything I need to get started. Let me know if you have any other context that I'm missing
@jonathankwok @RichardBlair @mdking @garethson @kmcphillips