Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
node: ['18.12.0']
node: ['18.20.3']
steps:
- uses: actions/checkout@v3
name: Checkout [main]
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/shopify-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ on:
node-version:
description: 'Node version'
required: true
default: '18.12.0'
default: '18.20.3'
type: choice
options:
- 18.12.0
- 18.20.3
- 20.14.0
- 22.2.0
os:
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
node: ['18.12.0', '20.14.0', '22.2.0']
node: ['18.20.3', '20.14.0', '22.2.0']
steps:
- uses: actions/checkout@v3
name: Checkout [${{ github.ref_name }}]
Expand All @@ -72,20 +72,20 @@ jobs:
node-version: ${{ matrix.node }}
- name: Build
run: pnpm nx run-many --all --skip-nx-cache --target=build
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }}
- name: Lint
run: pnpm nx run-many --all --skip-nx-cache --target=lint
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }}
- name: Type-check
run: pnpm nx run-many --all --skip-nx-cache --target=type-check
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }}
- name: Bundle
run: pnpm nx run-many --all --skip-nx-cache --target=bundle
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }}
- name: Unit tests
run: pnpm nx run-many --all --skip-nx-cache --target=test --exclude=features
- name: Acceptance tests
if: ${{ matrix.node == '18.12.0' }}
if: ${{ matrix.node == '18.20.3' }}
run: pnpm nx run features:test
- name: Send Slack notification on failure
uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # pin@v1.23.0
Expand All @@ -99,7 +99,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- name: Run and save test coverage
uses: ./.github/actions/run-and-save-test-coverage
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }}
with:
branch-name: ${{ github.ref_name }}

Expand All @@ -111,7 +111,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
node: ['18.12.0']
node: ['18.20.3']
target: ['build', 'type-check', 'lint']
steps:
- uses: actions/checkout@v3
Expand All @@ -134,7 +134,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
node: ['18.12.0']
node: ['18.20.3']
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -158,7 +158,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
node: ['18.12.0']
node: ['18.20.3']
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -188,7 +188,7 @@ jobs:
- name: Setup deps
uses: ./.github/actions/setup-cli-deps
with:
node-version: 18.12.0
node-version: 18.20.3
- name: Build
run: pnpm build
- name: Refresh manifests
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
node: ['18.12.0', '20.14.0', '22.2.0']
node: ['18.20.3', '20.14.0', '22.2.0']
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -238,7 +238,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
node: ['18.12.0']
node: ['18.20.3']
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -260,7 +260,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
node: ['18.12.0']
node: ['18.20.3']
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"vitest": "^0.34.3"
},
"engines": {
"node": ">=18.12.0"
"node": ">=18.20.0"
},
"os": [
"darwin",
Expand Down