Skip to content

Conversation

@vividviolet
Copy link
Member

@vividviolet vividviolet commented Sep 24, 2025

WHY are these changes introduced?

New extensions should always have a typed shopify global according to the specified target. We no longer need to delete the tsconfig. This change is also needed to support non-preact templates like data extensions that only has a .js file.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Member Author

vividviolet commented Sep 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.75% (-0.03% 🔻)
13717/17418
🟡 Branches
72.47% (-0.19% 🔻)
6682/9220
🟡 Functions
78.8% (+0.02% 🔼)
3524/4472
🟡 Lines
79.09% (-0.04% 🔻)
12966/16395
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / type-generation.ts
71% 52.05% 88.89% 70.71%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ui_extension.ts
94.78% (-1.3% 🔻)
82.89% (-5.51% 🔻)
100%
96.43% (-1.53% 🔻)
🟢
... / extension.ts
91.11% (+0.58% 🔼)
74% (-0.07% 🔻)
91.67% (-0.33% 🔻)
90.91% (+0.59% 🔼)

Test suite run success

3328 tests passing in 1382 suites.

Report generated by 🧪jest coverage report action from cb6f4fd

@Fionoble Fionoble force-pushed the fio/trish/cleanup-polaris-flag branch from ad36509 to 6767e9f Compare September 26, 2025 17:39
@vividviolet vividviolet marked this pull request as ready for review September 26, 2025 18:54
@vividviolet vividviolet requested a review from a team as a code owner September 26, 2025 18:54
We will always want a tsconfig so we can type the shopify global
@vividviolet vividviolet force-pushed the fio/trish/cleanup-polaris-flag branch from 6767e9f to 602abeb Compare September 26, 2025 18:57
@vividviolet vividviolet force-pushed the Remove_code_to_delete_tsconfig_for_ui_extensions branch from 3c8f2d9 to cb6f4fd Compare September 26, 2025 18:57
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

Copy link
Contributor

@isaacroldan isaacroldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fix that requires a patch release? or is not that urgent?

@vividviolet
Copy link
Member Author

Is this a fix that requires a patch release? or is not that urgent?

We do need it in the patch

@vividviolet vividviolet merged commit 40914a4 into fio/trish/cleanup-polaris-flag Sep 29, 2025
1 check was pending
@vividviolet vividviolet deleted the Remove_code_to_delete_tsconfig_for_ui_extensions branch September 29, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants