-
Notifications
You must be signed in to change notification settings - Fork 224
Remove code to delete the tsconfig for ui extensions #6429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code to delete the tsconfig for ui extensions #6429
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3328 tests passing in 1382 suites. Report generated by 🧪jest coverage report action from cb6f4fd |
ad36509 to
6767e9f
Compare
We will always want a tsconfig so we can type the shopify global
6767e9f to
602abeb
Compare
3c8f2d9 to
cb6f4fd
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
isaacroldan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a fix that requires a patch release? or is not that urgent?
We do need it in the patch |
40914a4
into
fio/trish/cleanup-polaris-flag

WHY are these changes introduced?
New extensions should always have a typed shopify global according to the specified target. We no longer need to delete the tsconfig. This change is also needed to support non-preact templates like data extensions that only has a
.jsfile.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist