Fix images not loading in theme app extensions #6614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our wrapper around fs's `readFile` sets a default of `{encoding:
'utf8'}` to the options. This will cause any binary files (like images
or fonts) to not be read properly.
There isn't a way to disable the encoding based on how the function is
currently typed so I'm switching to fs's version of `readFile` which
will handle all file types correctly automatically.
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @graygilmore! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251112222441Caution After installing, validate the version by running just |
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3356 tests passing in 1372 suites. Report generated by 🧪jest coverage report action from 9b97dfa |
gonzaloriestra
approved these changes
Nov 13, 2025
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
Good catch, thanks!
alfonso-noriega
approved these changes
Nov 13, 2025
EvilGenius13
approved these changes
Nov 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Re: https://community.shopify.dev/t/images-in-theme-app-extension-break-after-upgrading-to-shopify-cli-v3-87-0/25200
Images are failing to load in theme app extensions.
WHAT is this pull request doing?
Our wrapper around fs's
readFilesets a default of{encoding: 'utf8'}to the options. This will cause any binary files (like images or fonts) to not be read properly.There isn't a way to disable the encoding based on how the function is currently typed so I'm switching to fs's version of
readFilewhich will handle all file types correctly automatically.How to test your changes?
npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251112222441shopify app devChecklist