Skip to content

Conversation

@shauns
Copy link
Contributor

@shauns shauns commented Nov 21, 2025

WHY are these changes introduced?

This hooks the import of declarative definitions into the import-extensions command. It requires a selection of changes: unlike other extensions, these are never automatically imported.

Copy link
Contributor Author

shauns commented Nov 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shauns shauns marked this pull request as ready for review November 21, 2025 12:56
@shauns shauns requested a review from a team as a code owner November 21, 2025 12:56
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@shauns shauns force-pushed the shauns/09-17-dnm_dcdd_import branch from 1c85b8c to 6d881f4 Compare November 21, 2025 13:04
@shauns shauns force-pushed the shauns/dcdd-import-service branch from cca80dc to 375e9d7 Compare November 21, 2025 13:04
@shauns shauns force-pushed the shauns/09-17-dnm_dcdd_import branch from 6d881f4 to a215155 Compare November 21, 2025 13:11
@shauns shauns force-pushed the shauns/dcdd-import-service branch 2 times, most recently from 4f057f5 to 232d079 Compare November 21, 2025 14:15
@shauns shauns force-pushed the shauns/09-17-dnm_dcdd_import branch from a215155 to 04511b3 Compare November 21, 2025 14:15
@shauns shauns force-pushed the shauns/09-17-dnm_dcdd_import branch from 04511b3 to 39510fe Compare November 21, 2025 14:21
@shauns shauns force-pushed the shauns/dcdd-import-service branch from 232d079 to a61c3ab Compare November 21, 2025 14:21
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/environment.d.ts
@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
 /**
  * If true, the CLI should not use the Partners API.
  *
- * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
+ * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
  */
 export declare function blockPartnersAccess(): boolean;
 /**
packages/cli-kit/dist/public/node/session.d.ts
@@ -122,4 +122,15 @@ export declare function ensureAuthenticatedBusinessPlatform(scopes?: BusinessPla
  * @returns A promise that resolves when the logout is complete.
  */
 export declare function logout(): Promise<void>;
+/**
+ * Ensure that we have a valid Admin session for the given store, with access on behalf of the app.
+ *
+ * See  for access on behalf of a user.
+ *
+ * @param storeFqdn - Store fqdn to request auth for.
+ * @param clientId - Client ID of the app.
+ * @param clientSecret - Client secret of the app.
+ * @returns The access token for the Admin API.
+ */
+export declare function ensureAuthenticatedAdminAsApp(storeFqdn: string, clientId: string, clientSecret: string): Promise<AdminSession>;
 export {};
\ No newline at end of file
packages/cli-kit/dist/private/node/ui/components/Tasks.d.ts
@@ -1,7 +1,8 @@
 import { AbortSignal } from '../../../../public/node/abort.js';
+import { TokenizedString } from '../../../../public/node/output.js';
 import React from 'react';
 export interface Task<TContext = unknown> {
-    title: string;
+    title: string | TokenizedString;
     task: (ctx: TContext, task: Task<TContext>) => Promise<void | Task<TContext>[]>;
     retry?: number;
     retryCount?: number;

@shauns shauns marked this pull request as draft November 21, 2025 14:30
@shauns shauns changed the base branch from shauns/dcdd-import-service to graphite-base/6652 November 24, 2025 10:35
@shauns shauns closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant