-
Notifications
You must be signed in to change notification settings - Fork 224
Allow Partners API for extension migration queries #6702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3501 tests passing in 1409 suites. Report generated by 🧪jest coverage report action from 4d08d65 |
9b9a51f to
4d08d65
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/environment.d.ts@@ -53,9 +53,10 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
/**
* If true, the CLI should not use the Partners API.
*
+ * @param forceUsePartnersApi - If true, the CLI will force to use the Partners API.
* @returns True when the CLI should not use the Partners API.
*/
-export declare function blockPartnersAccess(): boolean;
+export declare function blockPartnersAccess(forceUsePartnersApi?: boolean): boolean;
/**
* If true, the CLI should not use the network level retry.
*
packages/cli-kit/dist/public/node/api/partners.d.ts@@ -11,9 +11,10 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
* @param cacheOptions - Cache options.
* @param preferredBehaviour - Preferred behaviour for the request.
* @param unauthorizedHandler - Optional handler for unauthorized requests.
+ * @param forceUsePartnersApi - If true, the request will be forced to use the Partners API.
* @returns The response of the query of generic type <T>.
*/
-export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
+export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler, forceUsePartnersApi?: boolean): Promise<T>;
export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
status?: string;
source?: string;
|
Contributor
Author
|
Closing in favor of #6708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist