Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

Reverts #6715

The release failed and I want to try this again with this change.

@gonzaloriestra gonzaloriestra requested review from a team as code owners December 15, 2025 10:55
@gonzaloriestra gonzaloriestra merged commit bbb96cb into stable/3.88 Dec 15, 2025
23 checks passed
@gonzaloriestra gonzaloriestra deleted the revert-6715-changeset-release/stable/3.88 branch December 15, 2025 10:56
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/http.d.ts
@@ -18,7 +18,7 @@ type AutomaticCancellationBehaviour = {
 } | {
     useAbortSignal: AbortSignal | (() => AbortSignal);
 };
-export type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
+type RequestBehaviour = NetworkRetryBehaviour & AutomaticCancellationBehaviour;
 export type RequestModeInput = PresetFetchBehaviour | RequestBehaviour;
 /**
  * Specify the behaviour of a network request.
packages/cli-kit/dist/public/node/ui.d.ts
@@ -335,7 +335,6 @@ export declare function renderTasks<TContext>(tasks: Task<TContext>[], { renderO
 export interface RenderSingleTaskOptions<T> {
     title: TokenizedString;
     task: (updateStatus: (status: TokenizedString) => void) => Promise<T>;
-    onAbort?: () => void;
     renderOptions?: RenderOptions;
 }
 /**
@@ -349,7 +348,7 @@ export interface RenderSingleTaskOptions<T> {
  * ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
  * Loading app ...
  */
-export declare function renderSingleTask<T>({ title, task, onAbort, renderOptions, }: RenderSingleTaskOptions<T>): Promise<T>;
+export declare function renderSingleTask<T>({ title, task, renderOptions }: RenderSingleTaskOptions<T>): Promise<T>;
 export interface RenderTextPromptOptions extends Omit<TextPromptProps, 'onSubmit'> {
     renderOptions?: RenderOptions;
 }
packages/cli-kit/dist/public/node/api/admin.d.ts
@@ -41,14 +41,6 @@ export declare function adminRequestDoc<TResult, TVariables extends Variables>(o
  * @returns - An array of supported API versions.
  */
 export declare function supportedApiVersions(session: AdminSession, preferredBehaviour?: RequestModeInput): Promise<string[]>;
-/**
- * GraphQL query to retrieve all API versions.
- *
- * @param session - Shopify admin session including token and Store FQDN.
- * @param preferredBehaviour - Custom request behaviour for retries and timeouts.
- * @returns - An array of supported and unsupported API versions.
- */
-export declare function fetchApiVersions(session: AdminSession, preferredBehaviour?: RequestModeInput): Promise<ApiVersion[]>;
 /**
  * Returns the Admin API URL for the given store and version.
  *
@@ -58,10 +50,6 @@ export declare function fetchApiVersions(session: AdminSession, preferredBehavio
  * @returns - Admin API URL.
  */
 export declare function adminUrl(store: string, version: string | undefined, session?: AdminSession): string;
-interface ApiVersion {
-    handle: string;
-    supported: boolean;
-}
 /**
  * Executes a REST request against the Admin API.
  *
@@ -94,5 +82,4 @@ export interface RestResponse {
     headers: {
         [key: string]: string[];
     };
-}
-export {};
\ No newline at end of file
+}
\ No newline at end of file
packages/cli-kit/dist/public/node/api/graphql.d.ts
@@ -47,7 +47,6 @@ export type GraphQLRequestDocOptions<TResult, TVariables> = GraphQLRequestBaseOp
     }>>;
     variables?: TVariables;
     unauthorizedHandler?: UnauthorizedHandler;
-    autoRateLimitRestore?: boolean;
 };
 export interface GraphQLResponseOptions<T> {
     handleErrors?: boolean;
packages/cli-kit/dist/private/node/ui/components/SingleTask.d.ts
@@ -3,8 +3,7 @@ interface SingleTaskProps<T> {
     title: TokenizedString;
     task: (updateStatus: (status: TokenizedString) => void) => Promise<T>;
     onComplete?: (result: T) => void;
-    onAbort?: () => void;
     noColor?: boolean;
 }
-declare const SingleTask: <T>({ task, title, onComplete, onAbort, noColor }: SingleTaskProps<T>) => JSX.Element | null;
+declare const SingleTask: <T>({ task, title, onComplete, noColor }: SingleTaskProps<T>) => JSX.Element | null;
 export { SingleTask };
\ No newline at end of file

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.17% 13842/17484
🟡 Branches 73.14% 6757/9239
🟡 Functions 79.31% 3550/4476
🟡 Lines 79.54% 13079/16443

Test suite run success

3450 tests passing in 1396 suites.

Report generated by 🧪jest coverage report action from 484d5f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant