Skip to content

[AnnouncementBar] Fixing an issue with block attributes #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ludoboludo merged 1 commit into from
Jan 24, 2025
Merged

[AnnouncementBar] Fixing an issue with block attributes #3646

ludoboludo merged 1 commit into from
Jan 24, 2025

Conversation

@alexandcote
Copy link
Contributor

@alexandcote alexandcote commented Oct 9, 2024 •
edited
Loading

PR Summary:

  1. Shopify attributes were not rendered when the section contained only one block
  2. The attributes were rendered multiple times per block when the section contained multiple blocks

Why are these changes introduced?

Improving the Theme Editor experience.

Testing steps/scenarios

  1. Open the theme editor
  2. Add the slideshow section with one block
  3. Hover the block in the sidebar, be sure the power preview outlines the block properly.
  4. Add another block to the section
  5. Hover the first block, be sure the power preview outlines the block properly.

Checklist

@alexandcote alexandcote self-assigned this Oct 9, 2024
ludoboludo
ludoboludo approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

cc: @Roi-Arthur mind reviewing that one as well ?

Roi-Arthur
Roi-Arthur approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Roi-Arthur Roi-Arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me
Got thrown by the step to "Add the slideshow section" for a second 😅

@ludoboludo ludoboludo merged commit d4a42ca into main Jan 24, 2025
@ludoboludo ludoboludo deleted the alexandcote/fixing-block-attributes-announcement-bar branch January 24, 2025 19:45
francescomaione1992 added a commit to Pakos-Devs/dawn that referenced this pull request Jan 25, 2025
@francescomaione1992
Merge pull request #1 from Shopify/main
f659ac0 
[AnnouncementBar] Fixing an issue with block attributes (Shopify#3646)
NathanScheele pushed a commit to Misha-Puff/dawn that referenced this pull request Mar 3, 2025
@nathan-scheele
[AnnouncementBar] Fixing an issue with block attributes (Shopify#3646)
1056348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludoboludo ludoboludo ludoboludo approved these changes

@Roi-Arthur Roi-Arthur Roi-Arthur approved these changes

@tyleralsbury tyleralsbury Awaiting requested review from tyleralsbury

Assignees

@alexandcote alexandcote

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandcote @ludoboludo @Roi-Arthur