Fix syntax issue in schema for email-signup-banner section #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoboludo
approved these changes
Nov 6, 2024
melissaperreault
approved these changes
Nov 6, 2024
NathanScheele
pushed a commit
to Misha-Puff/dawn
that referenced
this pull request
Nov 26, 2024
NathanScheele
pushed a commit
to Misha-Puff/dawn
that referenced
this pull request
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fixes syntax error in email-signup-banner section.
While it currently "works",
"templates": ["password"]should be invalid if not nested into"enabled_on"or"disabled_on", as shown by Theme checkWhy are these changes introduced?
Fixes invalid schema syntax.
Visual impact on existing themes
No impact on theme
Testing steps/scenarios