Skip to content

WIP2 #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
charlespwd wants to merge 14 commits into
base: cp-one-parser
Choose a base branch
from
Draft

WIP2 #2020

charlespwd wants to merge 14 commits into from

Conversation

@charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Dec 3, 2025

Architectural changes

  • parse_expression and safe_parse_expression have been removed from Tag and ParseContext
  • Parser methods now produce AST nodes instead of strings
    • Parser#expression produces a value,
    • Parser#string produces a string,
    • etc.

Breaking changes

  • Parser#expression is renamed to Parser#expression_string
  • safe_parse_expression methods are replaced by Parser#expression
  • parse_expression methods are replaced by Parser#unsafe_parse_expression

@charlespwd
Move safe_parse_expression into Parser.expression_node
c688f70 
- Make `Parser` accept the expression cache
- Remove `safe_parse_expression` from `ParseContext`
- Replace all usage of `safe_parse_expression` with `parser.expression_node`
@charlespwd
Move parse_expression to Parser.unsafe_parse_expression
158feb0 
- Add Parser#string
- Add Parser#unsafe_parse_expression
- Add private Parser#parse_expression
- Remove ParseContext.parse_expression
- Remove Tag.parse_expression
- Condition.parse_expression now takes a parser as argument
@charlespwd
Rename Parser#expression -> Parser#expression_string
44106dc
@charlespwd
Rename Parser#argument -> argument_string
123c2e3
@charlespwd
Rename Parser#expression_node -> Parser#expression
8222a1c
@charlespwd
Remove Expression#safe_parse
58cb885
@charlespwd
Extract Parser#string out of Expression.parse
8848065
@charlespwd
Extract Parser#number parse out of Expression.parse
96e1595
@charlespwd
Simplify parse_number
7b37ba6 
We don't need all the multi-dot logic in a world where number comes
out of the Lexer.
@charlespwd
Replace RangeLookup.parse with RangeLookup.create
58ce63e
@charlespwd
Move VariableLookup parsing logic to .parse instead of initializer
1023f3f 
Goal is to get rid of it entirely, but baby steps.
@charlespwd
Extract Parser#variable_lookup out of Expression.parse
0d80117
@charlespwd
Extract Parser#range_lookup out of Expression.parse
ab89281
@charlespwd
Replace Context[]'s Expression.parse with Parser#expression
5e3d8f4
@charlespwd charlespwd force-pushed the cp-expression-refactor branch from 9e95ad0 to 5e3d8f4 Compare December 3, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karreiro karreiro Awaiting requested review from karreiro

@graygilmore graygilmore Awaiting requested review from graygilmore

Assignees

No one assigned

Labels

#gsd:48203

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@charlespwd