Avoid using RARRAY_PTR #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
1-0-stable-shopify
branch
from
569781c to
5c0ee16
Compare
casperisfine
force-pushed
the
avoid-rarray-ptr
branch
2 times, most recently
from
5204306 to
53a59b0
Compare
peterzhu2118
reviewed
Feb 3, 2023
It cause the array to be marked as unprotected, when this happen enough times it triggers a major GC run.
casperisfine
force-pushed
the
avoid-rarray-ptr
branch
from
53a59b0 to
a3a86d5
Compare
peterzhu2118
reviewed
Feb 3, 2023
| arg4 = (char **) malloc((arg6+1)*sizeof(char *)); | ||
| for(i = 0; i < arg6; i ++) { | ||
| str = rb_string_value(&RARRAY_PTR(argv[3])[i]); | ||
| str = rb_ary_entry(argv[1], i); |
There was a problem hiding this comment.
This was argv[3] before and it's now argv[1]?
Author
There was a problem hiding this comment.
Woops. I'm surprised the test suite pass, but not sure how much we can trust it. Thanks for the catch.
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It cause the array to be marked as unprotected, when this happen enough times it triggers a major GC run.