This repository was archived by the owner on Jan 10, 2025. It is now read-only.
react-shortcuts: export Provider for enabling external ShortcutProvider implementors#375
Merged
marutypes merged 3 commits intoShopify:masterfrom Oct 26, 2018
Merged
Conversation
…er implementors The default `ShortcutProvider` is great for most React applications, but when React is being rendered into multiple locations on a page (for example, in a browser extension that extends multiple different locations on a page with React), the default `ShortcutProvider` does not work as it is intended to be a singleton. In order to implement one's own `ShortcutProvider` for this use case, the `ContextProvider` must be exported.
4 tasks
marutypes
approved these changes
Oct 24, 2018
Contributor
marutypes
left a comment
marutypes
left a comment
There was a problem hiding this comment.
Ideally we could fix this more holistically, but this is probably an OK escape hatch to have as well.
We might want to add an FAQ to the README with an example of how to use a custom provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
ShortcutProvideris great for most React applications, but whenReact is being rendered into multiple locations on a page (for example, in a
browser extension that extends multiple different locations on a page with
React), the default
ShortcutProviderdoes not work as it is intended to be a singleton.In order to implement one's own
ShortcutProviderfor this use case, theContextProvidermust be exported.