-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add Roast::Log class for standardized logging #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduces a clean, testable logging interface at Roast::Log that: - Provides standard log methods: debug, info, warn, error, fatal - Outputs to $stderr (testable via Minitest's capture_io) - Respects ROAST_LOG_LEVEL env var for log level configuration - Has reset! method for test isolation This addresses issue #390 (rename Roast::Helpers::Logger to Roast::Log). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mathiusj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfgrep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I added another commit (dca0250) to update some of the obvious places that would fall clearly under logs / stderr output in my opinion. There are other places like the following that I thought might fall under output / stdout which I didn't update. I thought that having the Lines 44 to 47 in 5446990
|
|
Let's keep the |

Summary
Roast::Logmodule as the central logging interface (addressesRoast::Loginstead ofRoast::Helpers::Logger#390)$stderrby default so the logs can be redirected separate from workflow output, it's also testable via Minitest'scapture_ioRoast::Log.logger = custom_loggerROAST_LOG_LEVELenv var for log level configurationclaude_invocation.rbto useRoast::Logfor unhandled message warnings🤖 Generated with Claude Code