Skip to content

YJIT: fix leak, remove unused field on block_t #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XrXr merged 1 commit into from
Mar 5, 2021
Merged

YJIT: fix leak, remove unused field on block_t #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ujit_codegen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,8 +1399,6 @@ gen_oswb_iseq(jitstate_t* jit, ctx_t* ctx, struct rb_call_data * cd, const rb_ca
return UJIT_CANT_COMPILE;
}

rb_gc_register_mark_object((VALUE)iseq); // FIXME: intentional LEAK!

// Create a size-exit to fall back to the interpreter
uint8_t* side_exit = ujit_side_exit(jit, ctx);

Expand Down
1 change: 0 additions & 1 deletion ujit_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ add_block_version(blockid_t blockid, block_t* block)
{
// By writing the new block to the iseq, the iseq now
// contains new references to Ruby objects. Run write barriers.
RB_OBJ_WRITTEN(iseq, Qundef, block->dependencies.iseq);
RB_OBJ_WRITTEN(iseq, Qundef, block->dependencies.cc);
RB_OBJ_WRITTEN(iseq, Qundef, block->dependencies.cme);

Expand Down
1 change: 0 additions & 1 deletion ujit_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ typedef struct ujit_block_version
struct {
VALUE cc;
VALUE cme;
VALUE iseq;
} dependencies;

// Index one past the last instruction in the iseq
Expand Down
2 changes: 0 additions & 2 deletions ujit_iface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,6 @@ rb_ujit_iseq_mark(const struct rb_iseq_constant_body *body)

rb_gc_mark_movable(block->dependencies.cc);
rb_gc_mark_movable(block->dependencies.cme);
rb_gc_mark_movable(block->dependencies.iseq);

// Walk over references to objects in generated code.
uint32_t *offset_element;
Expand All @@ -710,7 +709,6 @@ rb_ujit_iseq_update_references(const struct rb_iseq_constant_body *body)

block->dependencies.cc = rb_gc_location(block->dependencies.cc);
block->dependencies.cme = rb_gc_location(block->dependencies.cme);
block->dependencies.iseq = rb_gc_location(block->dependencies.iseq);

// Walk over references to objects in generated code.
uint32_t *offset_element;
Expand Down