Handle empty lisp files #160
Open
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty lisp file currently results in
```
compile error: `do` expected at least 1 argument; found 0
Traceback:
In main, define __shadowenv__900_rx_dev_yaml_env.lisp
In main, operator do
(do)
```
on `shadowenv hook`.
While an empty lisp file is not particularly useful, it shouldn't break
shadowenv. By adding an empty `()` before the actual content, we ensure
the program we create is valid, without changing the behaviour of any
lisp file that has content.
Contributor
Author
|
@burke Has this perhaps fallen off your radar because it was opened while you were on holiday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty lisp file currently results in
on
shadowenv hook.While an empty lisp file is not particularly useful, it shouldn't break shadowenv. By adding an empty
()before the actual content, we ensure the program we create is valid, without changing the behaviour of any lisp file that has content.