This repository was archived by the owner on Jul 14, 2022. It is now read-only.
👌 Change whitelist to blacklist #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marutypes
changed the title
kevinhughes27
approved these changes
Nov 28, 2017
Contributor
jamiemtdwyer
left a comment
jamiemtdwyer
left a comment
There was a problem hiding this comment.
Let's add fulfillment_services too I guess
AWaselnuk
approved these changes
Nov 28, 2017
marutypes
force-pushed
the
change-whitelist-to-blacklist
branch
from
d46e45e to
91e9316
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
This PR switches the whitelist to a blacklist with the routes outlined by @jamiemtdwyer. Running out of time tonight so I'll push adding tests to next time.