Check that we disable pylint messages by name and not code #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfournie
force-pushed
the
disable_by_name
branch
from
a352731 to
c164a14
Compare
Contributor
|
I believe the checkers have access to the linter as a member of |
JasonMWhite
reviewed
Mar 13, 2017
| """.strip()) | ||
|
|
||
| with self.assertAddsMessages(*[ | ||
| pylint.testutils.Message('disable-name-only', line=line, args={'code': code, 'name': 'unknown'}) |
There was a problem hiding this comment.
Why doesn't the linter know the suggested name for any of these codes?
Contributor
Author
There was a problem hiding this comment.
In tests it's not a real linter, it's a pylint.testutils.UnittestLinter which has no msgs_store to query.
There was a problem hiding this comment.
If there's a way to add this info to the linter to prove that it actually pulls it out, then we should add that. If it's too hacky though, don't worry about it.
cfournie
force-pushed
the
disable_by_name
branch
from
155c83b to
78f5236
Compare
JasonMWhite
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ensure that source code disables rules by message name and not message code. Fixes #32.
If a bad message code is mentioned in a disable comment, in addition to
bad-option-valuewe output a message suggestingunknownas a code (in casebad-option-valuehas been disabled):