This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Fix MissingTemplate ignore config interactions
#613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
fix/589-missing-template-ignore-interactions
branch
from
c16f6b6 to
febc0e7
Compare
charlespwd
force-pushed
the
fix/589-missing-template-ignore-interactions
branch
from
febc0e7 to
503cb73
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589
Fixes #489
Approach used:
If you're ignoring a file, then we shouldn't be able to flag it as missing. Global and check
ignoreconfigs are merged with theignore_missingconfig for the check.