This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Fixes theme-check-disable when disable comment is followed by another #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kind of weird edge case. If the theme-check-disable (:all) comment was followed by another comment, then the theme-check-disable (:all) comment was made to only apply on the range of the followup comment. The fix is to not do that when theme-check-disable :all is meant to be applied to the entire document. Fixes #583
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of weird edge case. If the theme-check-disable (:all) comment was followed
by another comment, then the theme-check-disable (:all) comment was made to only
apply on the range of the followup comment.
The fix is to not do that when theme-check-disable :all is meant to be
applied to the entire document.
Fixes #583