Conversation
Agent-Logs-Url: https://github.com/Shougo/ddc.vim/sessions/bc7390b2-9739-4965-a027-447fefc6c1f2 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Shougo/ddc.vim/sessions/bc7390b2-9739-4965-a027-447fefc6c1f2 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Shougo/ddc.vim/sessions/bc7390b2-9739-4965-a027-447fefc6c1f2 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Shougo/ddc.vim/sessions/bc7390b2-9739-4965-a027-447fefc6c1f2 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update denops loader.ts for improved path registration
loader: make registerPath concurrency-safe and add registerPaths (from dpp.vim PR #39)
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the concurrency fixes from dpp.vim PR #39 to ddc.vim, adapted for ddc's three extension types (
ui,source,filter) and its alias system.denops/ddc/loader.tsregisterPathrewrite: I/O (Deno.stat+importPlugin) now runs outside the lock, enabling concurrent registrations of different paths to proceed in parallel. Shared state (#exts,#checkPaths) is updated inside the lock with a double-checked re-entry guard.pathis already in#checkPaths, skipping all I/O.registerPaths(type, paths)added: fans out toregisterPathviaPromise.allSettled, absorbing per-path errors withconsole.errorrather than throwing.#registerprivate method and theModtype.Tests (
denops/ddc/tests/)loader_concurrent_test.ts: covers single-path registration, concurrent same-path idempotency, concurrent different-path registration, non-existent path rejection,registerPathswith mixed valid/invalid paths, and re-registration no-op.tests/testdata/source_{alpha,beta,gamma}.ts: minimalSourceclass fixtures used by the tests.Original prompt
This pull request was created from Copilot chat.