Refactor expand item with async#39
Merged
Shougo merged 1 commit intoShougo:mainfrom Jan 14, 2023
Merged
Conversation
ed02115 to
d7980d0
Compare
Owner
|
Merged. |
Shougo
added a commit
that referenced
this pull request
Apr 5, 2026
loader: make registerPath concurrency-safe and add registerPaths (port of dpp.vim PR #39)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
前段のリファクタリングで並行処理が整理できたので、redraw抑制のためにexpand中のtreePathをSetで管理するのではなく全ての展開処理が終わったらredrawするインターフェースにできました。
Set(expandedPath)はredraw待ちとしての役目は終えますが、tree復元で使用するのに利用する(今も暫定措置で利用されている)ので削除していません。
(refactor gatherItems with async generator by hori-ryota · Pull Request #38 · Shougo/ddu.vim のマージ & rebase待ち)