Conversation
…sts (from dpp.vim PR #39) Agent-Logs-Url: https://github.com/Shougo/ddx.vim/sessions/c68055b7-4369-43dc-a9da-35b58e968462 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Shougo/ddx.vim/sessions/c68055b7-4369-43dc-a9da-35b58e968462 Co-authored-by: Shougo <41495+Shougo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update loader.ts for registerPath behavior
loader: make registerPath concurrency-safe and add registerPaths (from dpp.vim PR #39)
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the concurrency improvements from dpp.vim PR #39 to ddx.vim, adapted for its
DdxExtType = "ui" | "analyzer"type system.loader.tsregisterPath: I/O (Deno.stat+importPlugin) now runs outside the lock so concurrent registrations of different paths proceed in parallel. State updates (#uis,#analyzers,#checkPaths) remain locked, with a re-check inside the lock to handle races. An unlocked fast-path at the top skips already-registered paths entirely.registerPaths(type, paths): New public method — fans out toregisterPathviaPromise.allSettled, absorbs per-path errors withconsole.error, never throws.#registerhelper and unusedModtype.Tests
denops/ddx/tests/loader_concurrent_test.ts: covers single registration, concurrent same-path idempotency, concurrent different-path registration, non-existent path throws,registerPathssuccess,registerPathspartial-failure tolerance, concurrentregisterPathsidempotency, re-registration no-op, and fixture URL round-trip.denops/ddx/tests/testdata/ui_{alpha,beta,gamma}.ts: minimalUifixture classes for test use.Original prompt
This pull request was created from Copilot chat.