Changes from Jan for sleep_monotonic #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikepurvis The only way to test this is to stress the all CPUs while changing system time. |
|
Looks good. Monotonic time is the key to healthy life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As captured in https://github.com/SimbeRobotics/tally/issues/4958#issuecomment-2981669392
Note that I haven't tried to fix up or make the whitespace consistent; I'd only want to use an automatic formatter and I don't think it's worth the risk if we aren't really maintaining this long-term.
@trisol I don't have a sense what the testing strategy should be for this. Do we just cut a release and try it out? Do we have a way to trigger the conditions that the monotonic timer patch addresses?