Skip to content

Mismatch between README.md and AddTimestamp.cs#4

Merged
SimonCropp merged 1 commit into
SimonCropp:masterfrom
ied206:master
Sep 11, 2018
Merged

Mismatch between README.md and AddTimestamp.cs#4
SimonCropp merged 1 commit into
SimonCropp:masterfrom
ied206:master

Conversation

@ied206
Copy link
Copy Markdown
Contributor

@ied206 ied206 commented Sep 10, 2018

This PR solves mismatch of format string between README.md and AddTimestamp.cs

README.md states that timestamp is saved with format string of yyyy-MM-dd.

### Adds the following attribute to your assembly

    [assembly: Timestamp("yyyy-MM-dd")]

So for example if you compile your assembly on the 20th of November 2013 the timestamp will be.

    [assembly: Timestamp("2013-11-20")]

AddTimestamp.cs is using format string of yyyy-MM-ddTHH:mm:ss.fffZ.

        void CreateTempAssemblyInfo()
        {
            var timestampUsage = $@"
// <auto-generated/>
using Timestamp;
[assembly: Timestamp(""{DateTime.UtcNow:yyyy-MM-ddTHH:mm:ss.fffZ}"")]
";

Testing reveals nuget package's behavior is consistent with AddTimestamp.cs, so update README.md.

- Reflect change of format string
@ied206 ied206 changed the title Mismatch between README.md and AddTimestamp.cs Mismatch between README.md and AddTimestamp.cs Sep 10, 2018
@SimonCropp
Copy link
Copy Markdown
Owner

@ied206 thanks

@SimonCropp SimonCropp merged commit 0532ffc into SimonCropp:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants