[MS-1339] MFID: add HAS_NUMBER_NO_ID skip reason (#1592)

* [MS-1339] Adding 'Has number, no card (booklet)' skip reason for MFID

* [MS-1339] Adding `HAS_NUMBER_NO_ID` credential skip reason

(cherry picked from commit cefefb6)

Author: alexandr-simprints

feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/skip/ExternalCredentialSkipFragment.kt

@@ -42,6 +42,7 @@ class ExternalCredentialSkipFragment : Fragment(R.layout.fragment_external_crede
     private fun initViews(credentialTypes: List<ExternalCredentialType>) = with(binding) {
         mapOf(
             title to IDR.string.mfid_skip_title,
+            skipReasonHasNumberNoId to IDR.string.mfid_skip_reason_has_number_no_id,
             skipReasonDoesNotHaveDocument to IDR.string.mfid_skip_reason_does_not_have,
             skipReasonDidNotBring to IDR.string.mfid_skip_reason_did_not_bring,
             skipReasonIncorrect to IDR.string.mfid_skip_reason_incorrect,
@@ -67,7 +68,9 @@ class ExternalCredentialSkipFragment : Fragment(R.layout.fragment_external_crede
                     reasonTextInput.text.toString().isNotEmpty()
                 }
 
-                else -> true
+                else -> {
+                    true
+                }
             }
             buttonSkip.isEnabled = isSkipButtonEnabled
         }
@@ -95,6 +98,7 @@ class ExternalCredentialSkipFragment : Fragment(R.layout.fragment_external_crede
     }
 
     private fun viewIdToOption(checkedId: Int) = when (checkedId) {
+        R.id.skipReasonHasNumberNoId -> ExternalCredentialSelectionEvent.SkipReason.HAS_NUMBER_NO_ID
         R.id.skipReasonDoesNotHaveDocument -> ExternalCredentialSelectionEvent.SkipReason.DOES_NOT_HAVE_ID
         R.id.skipReasonDidNotBring -> ExternalCredentialSelectionEvent.SkipReason.DID_NOT_BRING_ID
         R.id.skipReasonIncorrect -> ExternalCredentialSelectionEvent.SkipReason.BROUGHT_INCORRECT_ID

feature/external-credential/src/main/res/layout/fragment_external_credential_skip.xml

@@ -53,6 +53,13 @@
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="parent">
 
+                    <com.google.android.material.radiobutton.MaterialRadioButton
+                        android:id="@+id/skipReasonHasNumberNoId"
+                        style="@style/Widget.Simprints.RadioButton"
+                        android:layout_width="match_parent"
+                        android:layout_height="wrap_content"
+                        tools:text="Has number, no document (Booklet)" />
+
                     <com.google.android.material.radiobutton.MaterialRadioButton
                         android:id="@+id/skipReasonDoesNotHaveDocument"
                         style="@style/Widget.Simprints.RadioButton"

infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/remote/models/ApiExternalCredentialSelectionPayload.kt

@@ -31,6 +31,7 @@ internal data class ApiExternalCredentialSelectionPayload(
     @Keep
     @Serializable
     enum class ApiExternalCredentialSkipReason {
+        HAS_NUMBER_NO_ID,
         DOES_NOT_HAVE_ID,
         DID_NOT_BRING_ID,
         BROUGHT_INCORRECT_ID,
@@ -44,6 +45,7 @@ internal data class ApiExternalCredentialSelectionPayload(
 }
 
 internal fun SkipReason.toApiExternalCredentialSkipReason(): ApiExternalCredentialSkipReason = when (this) {
+    SkipReason.HAS_NUMBER_NO_ID -> ApiExternalCredentialSkipReason.HAS_NUMBER_NO_ID
     SkipReason.DOES_NOT_HAVE_ID -> ApiExternalCredentialSkipReason.DOES_NOT_HAVE_ID
     SkipReason.DID_NOT_BRING_ID -> ApiExternalCredentialSkipReason.DID_NOT_BRING_ID
     SkipReason.BROUGHT_INCORRECT_ID -> ApiExternalCredentialSkipReason.BROUGHT_INCORRECT_ID

infra/events/src/main/java/com/simprints/infra/events/event/domain/models/ExternalCredentialSelectionEvent.kt

@@ -84,6 +84,7 @@ data class ExternalCredentialSelectionEvent(
     @Keep
     @Serializable
     enum class SkipReason {
+        HAS_NUMBER_NO_ID,
         DOES_NOT_HAVE_ID,
         DID_NOT_BRING_ID,
         BROUGHT_INCORRECT_ID,

infra/resources/src/main/res/values/strings.xml

@@ -530,6 +530,7 @@
 
     <string name="mfid_add_document_title">Add this %1$s?</string>
     <string name="mfid_skip_title">Why did you skip the %1$s scan?</string>
+    <string name="mfid_skip_reason_has_number_no_id">Has number, no %1$s (Booklet)</string>
     <string name="mfid_skip_reason_does_not_have">Does not have %1$s</string>
     <string name="mfid_skip_reason_did_not_bring">Did not bring %1$s</string>
     <string name="mfid_skip_reason_incorrect">Brought incorrect %1$s</string>