[MS-1339] MFID: add HAS_NUMBER_NO_ID skip reason#1592
Merged
alexandr-simprints merged 2 commits intoFeb 17, 2026
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
Copilot,
luhmirin-s and
meladRaouf
There was a problem hiding this comment.
Pull request overview
This PR adds a new skip reason HAS_NUMBER_NO_ID for the MFID (Multi-Factor ID) credential skipping flow. This reason is intended for cases where a user has a credential number but not the physical credential document (e.g., has a booklet with the number but not the actual ID card). The change aligns with corresponding cloud backend updates mentioned in the PR description.
Changes:
- Added
HAS_NUMBER_NO_IDenum value to skip reason enums across domain and API layers - Added UI string resource with format placeholder for document type
- Added radio button option in the skip screen UI with proper view-to-enum mapping
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| infra/events/src/main/java/com/simprints/infra/events/event/domain/models/ExternalCredentialSelectionEvent.kt | Added HAS_NUMBER_NO_ID to the SkipReason enum as the first value |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/remote/models/ApiExternalCredentialSelectionPayload.kt | Added HAS_NUMBER_NO_ID to API enum and updated exhaustive mapping function |
| infra/resources/src/main/res/values/strings.xml | Added string resource mfid_skip_reason_has_number_no_id with format placeholder for credential type |
| feature/external-credential/src/main/res/layout/fragment_external_credential_skip.xml | Added radio button UI element for the new skip reason at the top of the list |
| feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/skip/ExternalCredentialSkipFragment.kt | Added mapping from radio button view ID to enum value; minor code formatting improvement in else block |
|
meladRaouf
approved these changes
Feb 16, 2026
BurningAXE
reviewed
Feb 16, 2026
BurningAXE
approved these changes
Feb 16, 2026
luhmirin-s
approved these changes
Feb 17, 2026
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* [MS-1339] Adding 'Has number, no card (booklet)' skip reason for MFID * [MS-1339] Adding `HAS_NUMBER_NO_ID` credential skip reason (cherry picked from commit cefefb6)
meladRaouf
pushed a commit
that referenced
this pull request
Mar 3, 2026
* [MS-1339] Adding 'Has number, no card (booklet)' skip reason for MFID * [MS-1339] Adding `HAS_NUMBER_NO_ID` credential skip reason (cherry picked from commit cefefb6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.1
Notable changes
HAS_NUMBER_NO_IDis added to the credential skip reasonsAdditional work checklist