MS-871 Record update support#1088

Merged

luhmirin-s merged 22 commits into

mainfrom

feature/MS-871-record-update

Mar 3, 2025

Contributor

luhmirin-s commented Feb 11, 2025 •

edited

Loading

Replaced a single PersonCreationEvent with BiometricReferenceCreationEvent per biometric capture.
Updated the enrolment event to have the list of biometrics-referenced IDs instead of the person creation event ID in the payload. Additionally, added the probe reference ID to the 1:1 and 1:N match events.
Added biometric reference ID to the local subject biometric sample records with a forced override/migration in the next sync cycle.
Added support for subject update event in down-sync.

More details about the changes are available in the design doc

cla-bot Bot added the ... label

luhmirin-s force-pushed the feature/MS-871-record-update branch from ef73c9a to 4bffaba Compare

February 12, 2025 09:37

luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team

February 12, 2025 09:52

luhmirin-s changed the title ~~[WIP] MS-871 record update support~~ MS-871 Record update support

luhmirin-s marked this pull request as ready for review

February 12, 2025 09:52

ybourgery requested changes

View reviewed changes

infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/up/tasks/EventUpSyncTask.kt

.../event-sync/src/main/java/com/simprints/infra/eventsync/sync/down/tasks/EventDownSyncTask.kt Outdated

.../event-sync/src/main/java/com/simprints/infra/eventsync/sync/down/tasks/EventDownSyncTask.kt Outdated

face/capture/src/main/java/com/simprints/face/capture/screens/FaceCaptureViewModel.kt Outdated

luhmirin-s requested a review from ybourgery

February 12, 2025 12:38

ybourgery reviewed

View reviewed changes

...ore/src/main/java/com/simprints/infra/enrolment/records/store/domain/models/SubjectAction.kt Outdated

luhmirin-s requested a review from ybourgery

February 12, 2025 13:48

alexandr-simprints approved these changes

View reviewed changes

luhmirin-s force-pushed the feature/MS-871-record-update branch 6 times, most recently from cbaabe5 to 57abb54 Compare

February 18, 2025 11:20

luhmirin-s force-pushed the feature/MS-871-record-update branch from 57abb54 to 5b3781a Compare

February 27, 2025 14:43

BurningAXE reviewed

View reviewed changes

...tric/src/test/java/com/simprints/feature/enrollast/screen/EnrolLastBiometricViewModelTest.kt Outdated

BurningAXE reviewed

View reviewed changes

...tric/src/test/java/com/simprints/feature/enrollast/screen/EnrolLastBiometricViewModelTest.kt Outdated

BurningAXE reviewed

View reviewed changes

...-check/src/main/java/com/simprints/feature/logincheck/usecases/StartBackgroundSyncUseCase.kt

BurningAXE reviewed

View reviewed changes

.../test/java/com/simprints/infra/events/event/domain/validators/EnrolmentEventValidatorTest.kt Outdated

BurningAXE reviewed

View reviewed changes

.../src/main/java/com/simprints/infra/events/event/domain/validators/EnrolmentEventValidator.kt Outdated

meladRaouf approved these changes

View reviewed changes

BurningAXE reviewed

View reviewed changes

infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/down/tasks/SubjectFactory.kt Outdated

infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/down/tasks/SubjectFactory.kt Outdated

...ync/src/main/java/com/simprints/infra/eventsync/status/down/domain/EventDownSyncOperation.kt

...ync/src/main/java/com/simprints/infra/eventsync/status/down/domain/EventDownSyncOperation.kt

infra/event-sync/schemas/com.simprints.infra.eventsync.status.EventSyncStatusDatabase/4.json

...java/com/simprints/infra/enrolment/records/store/local/EnrolmentRecordLocalDataSourceImpl.kt

...apture/src/main/java/com/simprints/fingerprint/capture/screen/FingerprintCaptureViewModel.kt Outdated

...rc/test/java/com/simprints/feature/orchestrator/usecases/response/EnrolSubjectUseCaseTest.kt Outdated

...rc/test/java/com/simprints/feature/orchestrator/usecases/response/EnrolSubjectUseCaseTest.kt Outdated

infra/events/src/main/java/com/simprints/infra/events/event/domain/models/OneToOneMatchEvent.kt

luhmirin-s added 22 commits

March 3, 2025 14:30


          MS-871 Add BiometricReferenceCreationEvent with boilerplate

4f6f3ef


          MS-871 Generalise reference ID creation to ensure it is consistent re…

267f778

…gardless of template source


          MS-871 Remove ENROLMENT_V1 event definition, it has been long enough

1d51771


          MS-871 Add ENROLMENT_V4 event implementation

3f4ab3f


          MS-871 Track Enrolment v4 instead of v2

1abf5f4


          MS-871 Route probe biometric reference ID from capture to matcher

9befa31


          MS-871 Add probe reference ID field to match events

0429c7c


          MS-871 Add biometric reference ID to sample models

302f965


          MS-871 Deprecating PersonCreationEvent

e3c5d91


          MS-871 Add EnrolmentRecordUpdate model and boilerplate

1e5029f


          MS-871 Handle record update down-sync event

e6ee157


          MS-871 Increase sync state database version to force destructive migr…

4a3580a

…ation


          MS-871 Update SID version label

99aca60


          MS-871 Fix double schedule of sync worker after successful login

b517052


          MS-871 Remove outdates samples when Subject is updated in local database

aad730f


          MS-871 Allow reference creation be synced as biometric event

abf5263


          MS-871 Move update logic into the realm transaction

c3b9797


          MS-871 Fix update event API model

6f7d1ca


          MS-871 Restore old SubjectAction name back to Creation

4fad11e


          MS-871 Replace deterministic reference ID with random UUID

cb971df


          MS-871 Fix naming and messaging in person creation references

ec02b36


          MS-871 Use all provided biometric references to create subject

ad779e2

luhmirin-s force-pushed the feature/MS-871-record-update branch from ee0bcd7 to ad779e2 Compare

March 3, 2025 12:51

sonarqubecloud Bot commented Mar 3, 2025

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

BurningAXE approved these changes

View reviewed changes

ybourgery approved these changes

View reviewed changes

luhmirin-s merged commit f374b20 into main

luhmirin-s deleted the feature/MS-871-record-update branch

March 3, 2025 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BurningAXE BurningAXE approved these changes

meladRaouf meladRaouf approved these changes

ybourgery ybourgery approved these changes

alexandr-simprints alexandr-simprints approved these changes

alex-vt Awaiting requested review from alex-vt alex-vt was automatically assigned from Simprints/sid-reviewers

TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

Labels

...