Skip to content

[MS-852] Add explicit class type to the tokenizable fields returned to CoSync#1111

Merged
meladRaouf merged 2 commits into
release/2025.1.0from
MS-852-CoSync-add-explicit-class-type-to-the-tokenized-fields-when-returning-to-CommCare2
Feb 20, 2025
Merged

[MS-852] Add explicit class type to the tokenizable fields returned to CoSync#1111
meladRaouf merged 2 commits into
release/2025.1.0from
MS-852-CoSync-add-explicit-class-type-to-the-tokenized-fields-when-returning-to-CommCare2

Conversation

@BurningAXE
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE commented Feb 19, 2025

  1. Added the concrete class type (Raw or Tokenized) to tokenizable fields returned to CoSync
  2. Given this - optimized CompareImplicitTokenizedStringsUseCase to only probe the tokenization state of TokenizableString.Raw values since if a value is TokenizableString.Tokenized we know its class was explicitly specified and can be sure of its tokenization state

@cla-bot cla-bot Bot added the ... label Feb 19, 2025
@BurningAXE BurningAXE changed the title Ms 852 co sync add explicit class type to the tokenized fields when returning to comm care2 [MS-852] Add explicit class type to the tokenized fields returned to CoSync Feb 19, 2025
@BurningAXE BurningAXE changed the title [MS-852] Add explicit class type to the tokenized fields returned to CoSync [MS-852] Add explicit class type to the tokenizable fields returned to CoSync Feb 19, 2025
@sonarqubecloud
Copy link
Copy Markdown

@BurningAXE BurningAXE requested review from a team, TristramN, alex-vt, alexandr-simprints, luhmirin-s, meladRaouf and ybourgery and removed request for a team February 19, 2025 15:06
@BurningAXE BurningAXE marked this pull request as ready for review February 19, 2025 15:06
@meladRaouf meladRaouf merged commit 0184805 into release/2025.1.0 Feb 20, 2025
@meladRaouf meladRaouf deleted the MS-852-CoSync-add-explicit-class-type-to-the-tokenized-fields-when-returning-to-CommCare2 branch February 20, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants