[MS-887] Fix Filtering Logic in CommCareIdentityDataSource

[meladRaouf]

There was a bug in the identification callouts from CommCare due to incorrect filtering logic in CommCareIdentityDataSource. The filtering logic was unintentionally excluding all records, causing identification failures.

The issue arose when building the subjectQuery in BuildMatcherSubjectQueryUseCase, where the filtering logic failed under different partitionType conditions:

partitionType = PROJECT → Both module ID and attendant ID are null.
partitionType = USER → The module ID in the query is null.
partitionType = MODULE → The attendant ID is null in the query.

Due to this, the filtering logic always failed, as it did not account for null values correctly.

I updated the filtering logic to correctly handle null values to ensure that valid records are no longer filtered out incorrectly.

[luhmirin-s]

Doesn't this break the usual comparison/equals contract in kotlin? Usually, when nulls are involved, comparisons return false, as there is nothing to compare.

[meladRaouf]

Yes, you are right, I reverted it back to false.

[luhmirin-s]

This line is very counter-intuitive since it reads as "filter items that match by all 3 fields".
I get the logic behind it, but the naming should be clearer, maybe at least something like "isNullOrMatching".

[meladRaouf]

done

[alexandr-simprints]

Do the functions need to be public?

[meladRaouf]

Done

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[BurningAXE]

Are the tests failing with the old implementation now?

[meladRaouf]

No Tests were OK.
I just added more parameters to one of the queries so that the tests covers all the flows in the filtering method

[BurningAXE]

My point is if they didn't catch the bug maybe they weren't :D