Skip to content

[MS-919] Organize Enrolment Records Modules#1117

Merged
meladRaouf merged 2 commits into
mainfrom
ms-919-organize-enrolment-reocrds-modules
Mar 3, 2025
Merged

[MS-919] Organize Enrolment Records Modules#1117
meladRaouf merged 2 commits into
mainfrom
ms-919-organize-enrolment-reocrds-modules

Conversation

@meladRaouf
Copy link
Copy Markdown
Collaborator

@meladRaouf meladRaouf commented Feb 26, 2025

Organize Enrolment Records Modules

  • Moved infra/enrollment-records-store to infra/enrollment-records/repository.
  • Moved infra/realm to infra/enrollment-records/realm-store.
  • Created an empty module infra/enrollment-records/room-store.

@cla-bot cla-bot Bot added the ... label Feb 26, 2025
@meladRaouf meladRaouf changed the title [MS-919] Organize Enrollment Records Module [MS-919] Organize Enrollment Records Modules Feb 26, 2025
@meladRaouf meladRaouf force-pushed the ms-919-organize-enrolment-reocrds-modules branch 2 times, most recently from bc7da5c to b433c86 Compare February 27, 2025 08:41
@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, luhmirin-s and ybourgery and removed request for a team February 27, 2025 08:43
@meladRaouf meladRaouf changed the title [MS-919] Organize Enrollment Records Modules [MS-919] Organize Enrolment Records Modules Feb 27, 2025
@meladRaouf meladRaouf force-pushed the ms-919-organize-enrolment-reocrds-modules branch from b433c86 to dc03d19 Compare February 27, 2025 08:47
@meladRaouf meladRaouf marked this pull request as ready for review February 27, 2025 08:51
@meladRaouf meladRaouf force-pushed the ms-919-organize-enrolment-reocrds-modules branch from dc03d19 to 00ccf11 Compare February 27, 2025 09:22
@meladRaouf meladRaouf force-pushed the ms-919-organize-enrolment-reocrds-modules branch from 00ccf11 to 77f5713 Compare February 27, 2025 09:45
}

android {
namespace = "com.simprints.infra.enrolment.records.room.store"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the room module was introduced to the repo in a separate PR when it has some implementation.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@meladRaouf meladRaouf force-pushed the ms-919-organize-enrolment-reocrds-modules branch from 77f5713 to c892fcc Compare March 3, 2025 09:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2025

@meladRaouf meladRaouf merged commit 0de395b into main Mar 3, 2025
@meladRaouf meladRaouf deleted the ms-919-organize-enrolment-reocrds-modules branch March 3, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants