Skip to content

MS926 Upload count fixes#1127

Merged
luhmirin-s merged 2 commits into
mainfrom
feature/MS-926-upload-count-fixes
Mar 5, 2025
Merged

MS926 Upload count fixes#1127
luhmirin-s merged 2 commits into
mainfrom
feature/MS-926-upload-count-fixes

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

Fixed two different issues that messed up up-sync event count reporting:

  • We counted all events for the max value, which included the events from open sessions and caused the total to be slightly inflated. One simple join removes this issue - now we only count the events that are actually going to be uploaded.
  • Events in the last uploaded scope were counted twice due to "COMPLETE" state carrying the count from the last "RUNNING" state in the up sync task, this caused the progress count to overshoot the "max" (sometimes by significant amounts):
I Started
D Received {"type":"EventUpSyncScope$ProjectScope","projectId":"xRmp384ofU6dvylF1Hao","operation":{"projectId":"xRmp384ofU6dvylF1Hao","lastState":"COMPLETE","lastSyncTime":1741169379383,"uniqueKey":"c96f77da-46c9-3791-a207-089c37d1b1a8"}}
D Uploaded 9 for batch : EventUpSyncProgress(operation=EventUpSyncOperation(projectId=xRmp384ofU6dvylF1Hao, lastState=RUNNING, lastSyncTime=1741169600103), progress=9)
D Uploaded 18 for batch : EventUpSyncProgress(operation=EventUpSyncOperation(projectId=xRmp384ofU6dvylF1Hao, lastState=COMPLETE, lastSyncTime=1741169603778), progress=9)
I [Success] Total uploaded: 18 / 9

@cla-bot cla-bot Bot added the ... label Mar 5, 2025
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team March 5, 2025 10:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2025

@luhmirin-s luhmirin-s merged commit 971d37d into main Mar 5, 2025
@luhmirin-s luhmirin-s deleted the feature/MS-926-upload-count-fixes branch March 5, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants